On 7/28/05, Holger Eitzenberger <[EMAIL PROTECTED]> wrote:
> I found a minor bug in e1000 debug initialization.
>
> The previous initaliazation resulted in log of level NETIF_MSG_DRV,
> NETIF_MSG_PROBE and NETIF_MSG_LINK ('debug' is used as shift factor)
> while it obviously was intended that only NETIF_MSG_DRV and
> NETIF_MSG_PROBE should be logged.
Thanks for looking into this, was there some message printed that you
weren't expecting?
Please don't apply this patch, we need the NETIF_MSG_LINK messages to
be printed because most everyone likes to know when their link came
up/went down.
You're correct in that debug should not be initialized by those flags,
it should simply be "3" because it is a shift value. We want the
resultant (1 << debug) - 1 to return 7 by default so that we print
DRV, PROBE, and LINK messages.
Jesse
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
