* David S. Miller <[EMAIL PROTECTED]> 2005-07-25 12:09 > Ok, so can we agree on the following patch? ing_filter() should > never see a NULL ->input_dev, and we could add a BUG() check > there for that invariant if you want.
This looks good to me, a input_dev==NULL means the packets origin is local. However, I think we should go the ifindex route, if we leave the softirq (e.g. requeue) we might reclassify the packet and an invalid ifindex is less serious than an invalid reference. > It seems like the skb->input_dev NULL check in act_api.c could > be eliminated, but I'm not so sure of that, can't that code get > called in the output path as well? The code block which uses input_dev is dead, TC_NCLS is never set as of now. Jamal might have use for it though? Generally, tcf_action_exec() may be called on both ingress and egress. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
