* Patrick McHardy <[EMAIL PROTECTED]> 2005-07-05 16:06 > Thomas Graf wrote: > >* jamal <[EMAIL PROTECTED]> 2005-07-05 09:04 > > > >>BTW, enqueue returning the code by calling the qdisc::drop() - is that > >>gonna cause some issues? > > > >It returns NET_XMIT_DROP which is not really black hole behaviour > >but should never produce side effects. > > It has side-effects on locally originated TCP connections. You should > probably return NET_XMIT_SUCCESS.
I don't see the notification as a negative side-effect, it is intented. It sure depends on the actual use of this blackhole qdisc, I agree that the term black hole would imply NET_XMIT_SUCESS, OTOH not reporting the drop means that the stack will do unnecessary work. I'm not sure what's better, maybe it should be configureable. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
