On Tue, 7 Jul 2026 13:29:06 GMT, EunHyunsu <[email protected]> wrote: >> When `expiryDate2DeltaSeconds()` fails to parse the Expires attribute >> against all date formats, it returns 0. The caller in >> `assignMaxAgeAttribute()` then sets `maxAge=0`, which causes `hasExpired()` >> to return true. Per RFC 6265 section 5.2.1, an unparseable Expires value >> should be ignored, leaving `maxAge=-1` (session cookie). >> >> This fix introduces a sentinel constant (`Long.MIN_VALUE`) as the return >> value for parse failure, since 0 is a valid delta for dates that match the >> creation time. The caller checks for this sentinel and skips the maxAge >> assignment when parsing fails. >> >> A new test in `MaxAgeExpires` verifies that unparseable Expires values are >> correctly ignored. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > EunHyunsu has updated the pull request incrementally with one additional > commit since the last revision: > > 8380549: Update ExpiredCookieTest for unparseable Expires behavior
Would it be possible to resync this PR with the latest master branch so that the patch will apply cleanly? There has been changes in at least one test `MaxAgeExpires.java` since this PR was opened. ------------- PR Comment: https://git.openjdk.org/jdk/pull/30341#issuecomment-4960349117
