On Fri, 27 Feb 2026 03:12:24 GMT, Koushik Muthukrishnan Thirupattur <[email protected]> wrote:
>> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Bound the memory usage when decompressing CompressedCertificate > > src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java line 77: > >> 75: private final ReentrantLock contextLock = new ReentrantLock(); >> 76: >> 77: // Avoid compressing local certificates repeatedly for every >> handshake. > > NIT: The existing comment explains the motivation, but can we also add a > short note that this cache is per SSLContext and reasoning on the size ? I think it's obvious that it's per `SSLContext` because we add it as an instance variable of `SSLContext`. About reasoning on the size: we currently don't do it for any other caches, so I think it would be against the established convention and overly verbose. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28682#discussion_r2865898432
