On Wed, 11 Sep 2024 19:18:18 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> did you remove mswsock from libjava or from libnio? Libnio libraries are >> listed >> [here](https://github.com/openjdk/jdk/blob/f57b6f13e9f375bfd2e8a05afd2b900a4d42285e/make/modules/java.base/Lib.gmk#L89). >> There's no FileDispatcherImpl.obj in libnio. > > Apparently I did remove it from libjava and not libnio. It will be fixed in > the next commit. Thanks for being persistent. Just to be absolutely clear: All my other comments about removing unneeded libraries were about libnio, not libjava. I realize I made the comment in the PR next to libjava, but my intention was to ask if the list of libraries for libnio could be trimmed down. Can you confirm that you really checked this for libnio, and not libjava, or -- better yet -- recheck these and making sure that you check it for libnio? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1755463756
