That is reasonable - but somehow I missed that reply (regarding OCA, etc).
More than willing to sign the OCA for a PR. As to the code from another project - clearly that wouldn’t work - so I was thinking more about changes that would allow someone to supply a websockets impl outside of the jdk. Anyway, thanks for the update - I’ll need to go back and see why I missed it - I thought I had just been ignored :) > On Jan 22, 2024, at 3:08 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 22/01/2024 08:43, Robert Engels wrote: >> See github.com/robaho/httpserver for a more capable fork of the JDK code. >> >> Would love to create a PR to move the core changes back into the JDK but the >> net-dev folks don’t seem to be interested > > As I recall, it wasn't really possible to do any assessment because the > "contribution" wasn't covered by the OCA. In addition, I think you said in > one of the mails that it includes code from another project (for websocket or > HTTP upgrade?) and it's a big deal to have to import and work through the > license issues with 3rd party code. > > At a high level it seems reasonable to update the HTTP server implementation > to work better with virtual threads but updating it to be a more fully > featured HTTP server goes beyond what this HTTP server was/is intended for. > > -Alan > >
