On Thu, 3 Feb 2022 16:16:32 GMT, Michael McMahon <micha...@openjdk.org> wrote:

>> This change updates the tests in question to handle the case where sym link 
>> creation is not supported, as observed on Windows 11 where additional 
>> privileges are required to create sym links.
>> 
>> Testing: tier 1-3 across platforms, plus tests in question on Windows 11 
>> specifically
>
> test/jdk/com/sun/net/httpserver/simpleserver/CustomFileSystemTest.java line 
> 444:
> 
>> 442:     }
>> 443: 
>> 444:     private boolean createSymLink(Path symlink, Path target) {
> 
> Seems like createSymLink should actually return true or false, or if it 
> throws an exception in one case, then it should be void, in which case you 
> wouldn't need the if statement in the calling code

Good catch, that makes for cleaner code - I'll refactor.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7335

Reply via email to