On Tue, 11 Jan 2022 16:33:57 GMT, Daniel Jelinski <d...@openjdk.java.net> wrote:

>> With this patch DefaultProxySelector first attempts to use proxy config 
>> autodetection (http://wpad/wpad.dat) when that is configured and available.
>> If proxy config autodetection is unavailable, selector tries to use 
>> configured proxy script (again, if configured and available)
>> If both the above options fail, selector uses the configured proxy.
>> 
>> Verified on Windows 10 that:
>> - when `fAutoDetect` is true, http://wpad/wpad.dat refers to an existing 
>> file, the file has correct syntax and returns a proxy, that proxy is used
>> - when `fAutoDetect` is true, but the autoconfig file is not available / 
>> unusable for any reason, selector fails over to the next configured method
>> - when `lpszAutoConfigUrl` is set and usable, the proxy returned is used
>> - when `lpszAutoConfigUrl` is not set or unusable, selector fails over to 
>> next method
>> - when `lpszProxy` is configured, that proxy is used
>> - otherwise selector uses direct connection
>> 
>> The proxy configuration scripts are cached on system level, so testing 
>> (alternating between good and broken autoconfig script) may require waiting 
>> for the caches to invalidate.
>
> Daniel Jelinski has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Update copyright year

Marked as reviewed by dfuchs (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5995

Reply via email to