On Tue, 9 Mar 2021 18:13:24 GMT, Daniel Fuchs <[email protected]> wrote:
>> Now that DatagramSocket has been updated by JDK-8237352 to support joining
>> multicast group, this sentence in the API class level documentation of
>> MulticastSocket is obsolete and should be removed:
>>
>> "A MulticastSocket is a (UDP) DatagramSocket, with additional capabilities
>> for
>> joining "groups" of other multicast hosts on the internet."
>>
>> Not sure whether this requires a CSR. I guess not?
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Improved first sentence
Marked as reviewed by alanb (Reviewer).
src/java.base/share/classes/java/net/MulticastSocket.java line 40:
> 38: * The {@code MulticastSocket} class additionally defines
> 39: * convenient setter and getter methods for socket options
> 40: * that are commonly used by multicasting applications.
I think this looks okay.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2842