On Fri, 12 Feb 2021 08:50:14 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
> There seems to be an early return in > Java_sun_nio_ch_sctp_SctpChannelImpl_receive0 that misses freeing memory. > > Sonar reports : > https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=c&open=AXck8Cl0BBG2CXpcnjFu&resolved=false&severities=BLOCKER&types=BUG > > Potential leak of memory pointed to by 'newBuf' > I adjusted the early return and added freeing memory . > > > Btw. while adjusting Java_sun_nio_ch_sctp_SctpChannelImpl_receive0 , I > started to wonder what happens to the allocated memory in the same file in > handleSendFailed ( if ((addressP = malloc(dataLength)) == NULL) ) in > early return cases incl. the CHECK_NULL , is there some deallocation missing > there too ? This change looks fine. I don't know about handleSendFailed(). ------------- Marked as reviewed by bpb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2540
