> By moving string splitting and concatenation into the canonizeString utility, > we can defer allocation until we determine that canonization is required. > This saves two string allocations and a string concat for the common case > where canonization is not required. > > As a refactoring, move ParseUtil.canonizeString/doCanonize into Handler since > that's the only call site. > > Finally, let's rename the method to canonizalizeString, since canonization is > an rather unrelated term.
eirbjo has updated the pull request incrementally with one additional commit since the last revision: As a part of the rename from "canonize" to "canonicalize", doCanonize should also be renamed. This was an oversight in the original PR. ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/2167/files - new: https://git.openjdk.java.net/jdk/pull/2167/files/6e169aa0..f4b543d6 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2167&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2167&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2167.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2167/head:pull/2167 PR: https://git.openjdk.java.net/jdk/pull/2167
