Hi Daniel, On Tue, Jan 19, 2021 at 2:12 PM Daniel Fuchs (sun) <daniel.fu...@oracle.com> wrote:
> Hi Vitaly, > > On 19/01/2021 19:01, Vitaly Davidovich wrote: > > That was an API mistake in Java 1.4. When DatagramChannel was > > updated to support joining multicast groups (in Java 7) it was able > > to get the parameters right. > > > > Would it make sense to make a note of this aspect in joinGroup's javadoc? > > > > > > There's some veiled hint about that in the API note in the > MulticastSocket class level API documentation (that we added > in JDK 15): > > > https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/net/MulticastSocket.html > > <<< > API Note: > DatagramChannel implements the MulticastChannel interface and > provides an alternative API for sending and receiving multicast > datagrams. The MulticastChannel API supports both any-source and > source-specific multicast. > >>> > For some reason, I completely overlooked that :). And MulticastChannel specifies its join APIs in terms of InetAddress. Ok great, thanks for highlighting this more. > > But yes, as Alan says, the javadoc could still be improved. > best regards, > > -- daniel > Thanks
