On Wed, 18 Nov 2020 15:45:02 GMT, Sean Coffey <coff...@openjdk.org> wrote:

>> Sean Mullan has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   More test changes.
>
> test/lib/jdk/test/lib/security/SecurityUtils.java line 64:
> 
>> 62:     }
>> 63: 
>> 64:     private static void removeFromDisabledAlgs(String prop, List<String> 
>> algs) {
> 
> Useful utility method. Maybe it can be made public/ opened up and renamed to 
> something like "removeFromSecurityProperty" perhaps  ? could be done at a 
> later time perhaps.

Yes, that's the main reason why I put that code into a separate method, so that 
we could consider adding more methods that call it or using it more generally 
in subsequent fixes where we need to re-enable disabled algorithms.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1235

Reply via email to