On Thu, 5 Nov 2020 16:30:31 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8246741: Corrected summary tag, moved record declaration
>
> test/jdk/java/net/NetworkInterface/UniqueMacAddressesTest.java line 46:
>
>> 44:
>> 45: static PrintStream log = System.err;
>> 46: record NetIfPair(String interfaceName, byte[] address) {}
>
> Nit: maybe add a blank line, and a comment:
> static PrintStream log = System.err;
>
> // A record pair (NetworkInterface::name,
> NetworkInterface::hardwareAddress)
> record NetIfPair(String interfaceName, byte[] address) {}
I agree, this is more clear for some one new looking at the test. Will add in
that comment now
-------------
PR: https://git.openjdk.java.net/jdk/pull/1076
