On Tue, 22 Sep 2020 16:20:17 GMT, Patrick Concannon <pconcan...@openjdk.org> wrote:
>> Hi, >> >> Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean >> up in Authenticator and BasicAuthenicator' >> ? >> This fix is set of formatting changes intended to clean up the javadoc of >> the following classes : >> >> `com.sun.net.httpserver.Authenticator` >> `com.sun.net.httpserver.Authenticator.Result` >> `com.sun.net.httpserver.Authenticator.Failure` >> `com.sun.net.httpserver.Authenticator.Success` >> `com.sun.net.httpserver.Authenticator.Retry` >> >> `com.sun.net.httpserver.BasicAuthenticator` >> >> This issue is a sub-task of >> [JDK-8252822](https://bugs.openjdk.java.net/browse/JDK-8252822) >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request incrementally with one > additional commit since the last revision: > > 8253053: fixed typos; added tags Looks generally good - just one minor comment below... src/jdk.httpserver/share/classes/com/sun/net/httpserver/BasicAuthenticator.java line 136: > 134: * Called for each incoming request to verify the > 135: * given name and password in the context of this > 136: * Authenticator's realm. Any caching of credentials Maybe remove the uppercase in "this Authenticator's realm" ------------- PR: https://git.openjdk.java.net/jdk/pull/301
