Hi Daniel, Thanks for taking a look.
Here is a link to the CSR: https://bugs.openjdk.java.net/browse/JDK-8251532 Kind regards, Patrick > On 13 Aug 2020, at 10:58, Daniel Fuchs <daniel.fu...@oracle.com> wrote: > > Hi Patrick, > > This looks fine to me. > You will need a CSR though. > > best regards, > > -- daniel > > On 13/08/2020 09:40, Patrick Concannon wrote: >> Hi, >> Could someone please review my fix for JDK-8189744 — 'Deprecate the >> JDK-specific API for setting socket options, jdk.net.Sockets’ ? >> The JDK-specific API `jdk.net.Sockets` has been redundant since Java SE 9 >> added standard methods to get/set socket options and retrieve per-Socket >> supported options. This fix deprecates the class and its public methods. >> webrev: http://cr.openjdk.java.net/~pconcannon/8189744/webrevs/webrev.00/ >> issue: https://bugs.openjdk.java.net/browse/JDK-8189744 >> Kind regards, >> Patrick >
