Hi, Daniel: Thanks for spotting these. I’ve made these changes and incorporated them into the new webrev below.
Alan: I’ve added the tags, and trimmed the debug message as you’ve suggested. http://cr.openjdk.java.net/~pconcannon/8240901/webrevs/webrev.02/ Kind regards, Patrick > On 12 Aug 2020, at 10:21, Alan Bateman <alan.bate...@oracle.com> wrote: > > > > On 11/08/2020 15:43, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my fix for JDK-8240901 — ‘Add a test to check >> that large datagrams are sent/received on the network correctly’ ? >> >> The tests `java/net/DatagramSocket/SendReceiveMaxSize.java` and >> `java/net/DatagramSocket/SendReceiveMaxSize.java` have been updated to check >> (on all platforms) that the sending and receiving of large datagrams across >> a network are sent, fragmented, and re-assembled correctly. Previously, this >> check was performed on macOS only. >> >> issue: https://bugs.openjdk.java.net/browse/JDK-8240901 >> webrev: http://cr.openjdk.java.net/~pconcannon/8240901/webrevs/webrev.00/ >> > The @bug list in this test is accumulating the list of issues that the test > covers so you can add to that. Also add `@key randomness` as the test now > depends on Random bytes in the payload. > > Did you mean to leave in the debug messages? If this is for tracing purposes > then you can print sendBuf and receiveBuf as their output has the buffer > position, limit and capacity in a more compact format. > > -Alan.
