Re: RFR 8241389: URLConnection::getHeaderFields returns result inconsistent with getHeaderField/Key for FileURLConnection, FtpURLConnection

[Michael McMahon]

Daniel,

Yes, good point. The webrev is updated in place at:

http://cr.openjdk.java.net/~michaelm/8241389/webrev.2/

Thanks,

Michael

On 22/05/2020 16:29, Daniel Fuchs wrote:

Hi Michael,

 126             } catch (IOException e) {
 127                 headerFields = super.getHeaderFields();
 128             }

I'm not sure that's correct. Could a second attempt to connect()
succeed later? If so it would be more correct to return
super.getHeaderFields() without setting the new field value.

best regards,

-- daniel


On 22/05/2020 16:18, Michael McMahon wrote:

Thanks for the comments Daniel.

Webrev updated at: http://cr.openjdk.java.net/~michaelm/8241389/webrev.2/

- Michael

O