Hi Rahul,
That looks very good!
Thanks for taking that on.
Not related to your fix, but could you update the
code that creates the HttpClient to explicitly require no
proxy? I suggest to update:
166 client =
HttpClient.newBuilder().sslContext(sslContext).build();
to:
client = HttpClient.newBuilder()
.proxy(HttpClient.Builder.NO_PROXY)
.sslContext(sslContext)
.build();
Not explicitly requiring NO_PROXY has been a source of
instability on certain environments - as it might pick
up system proxies.
best regards,
-- daniel
On 24/04/2020 15:58, Rahul wrote:
Hello,
Request to have my fix reviewed for the issue:
JDK-8242999 : http/2 client may not handle continuation frames correctly.
The fix updates jdk.internal.net.http.Stream.incoming(Http2Frame frame)
to handle
the scenario where a continuation with `END_HEADERS` may appear after a
header
frame, this was not being handled earlier.
Issue: https://bugs.openjdk.java.net/browse/JDK-8242999
Webrev:
http://cr.openjdk.java.net/~pconcannon/rayayada/8242999/webrevs/webrev.00/
--rahul
