Hi Patrick, > On 3 Apr 2020, at 14:47, Patrick Concannon <patrick.concan...@oracle.com> > wrote: > > ... > > Chris - I put in an extra check in the tests to ensure that the new code > doesn’t interfere with the Security Manager checks already present in the > source.
Thank you Patrick. > The new webrev can be found here: > http://cr.openjdk.java.net/~pconcannon/8240533/webrevs/webrev.01/ > > I have just a few more minor comments: I think there is a small cut’n’paste issue with test/jdk/java/nio/channels/DatagramChannel/SendPortZero.java 59 * @run testng/othervm -Djava.net.preferIPv4Stack=true ConnectPortZero <<< should be SendPortZero typo: Execption in two test summary tags There is no need to use two instance initializers, when one will suffice ;-) : 123 { perms.add( 124 new SocketPermission("127.0.0.1:0", "connect")); } 125 { perms.add( 126 new SocketPermission("0.0.0.0:0", "connect")); } Just: { perms.add(new SocketPermission("127.0.0.1:0", "connect")); perms.add(new SocketPermission("0.0.0.0:0", "connect")); } Thanks, -Chris.
