Hi Chris,
just looking at the supportedOptions method in the two classes
DatagramSocket and MulticastSocket, if I haven't misread them, are
they not the same?
As such MulticastSocket could inherit that method from DatagramSocket ?
(without the necessity to override)
regards
Mark
________________________________
From: net-dev <net-dev-boun...@openjdk.java.net> on behalf of Chris Hegarty
<chris.hega...@oracle.com>
Sent: Wednesday 1 April 2020 13:29
To: OpenJDK Network Dev list <net-dev@openjdk.java.net>
Subject: RFR [15] 8241988 DatagramSocket incorrectly caches the first set of
socket options
DatagramSocket incorrectly caches the first set of socket options that
it encounters (through an invocation of supportedOptions()),
subsequently returning that set of options regardless of what the
particular datagram socket impl actually supports.
Webrev:
https://cr.openjdk.java.net/~chegar/8241988/webrev/
JIRA:
https://bugs.openjdk.java.net/browse/JDK-8241988
This issue has been filed so as to extract the long(ish) standing issue
from the work being done to support JEP 373 [1]. The code changes in
this review are only slightly different to the changes being proposed in
the review for 373 [1], so can be merged will little effort.
-Chris.
[1] https://mail.openjdk.java.net/pipermail/net-dev/2020-April/013748.html
