Thanks John!
I have verified that indeed TLSv1.3 is selected by default,
and updated the fix as per your suggestion:
http://cr.openjdk.java.net/~dfuchs/webrev_8239052/webrev.01/
I also took the opportunity to add an @bug tag to
the HandshakeFailureTest.java which was missing from my
previous fix.
best regards,
-- daniel
On 21/02/2020 14:31, sha.ji...@oracle.com wrote:
Hi Daniel,
Not a review, but just a minor suggestion.
273 params.setProtocols(new String[]{"TLSv1.3"}); // TODO: This
is essential. Needs to be protocol impl
If this test doesn't concern a specific TLS protocol, this configuration
could be removed.
The default TLS protocol, exactly TLSv1.3 now, will be applied.
Best regards,
John Jiang
On 2020/2/21 18:01, Daniel Fuchs wrote:
Hi,
Please find below a test fix for:
8239052: java/net/httpclient/whitebox/SSLEchoTubeTestDriver.java
failed with BufferUnderflowException against TLSv1.3
https://bugs.openjdk.java.net/browse/JDK-8239052
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8239052/webrev.00/