Re: [PATCH] 7006496: Use modern Windows API to retrieve OS DNS servers

[Daniel Fuchs]

Hi,

Two small remarks:

ResolverConfigurationImpl.java:

  71             if (!l.contains(s)) {

Maybe empty strings should be skipped here too.

I believe it would be more correct to change this line:

 117             if (lastRefresh >= 0) {

to

 117             if (lastRefresh != -1) {

as System.nanoTime() can return negative values.


best regards,

-- daniel


On 09/01/2020 00:54, Aleks Efimov wrote:

Got the testing results: the CI is happy with the last patch - no JNDI test failures observed

Kind Regards,
Aleksei