Thanks ! May I get a second review ? Best regards, Matthias
From: Alan Bateman <alan.bate...@oracle.com> Sent: Freitag, 22. November 2019 16:52 To: Baesken, Matthias <matthias.baes...@sap.com>; net-dev@openjdk.java.net Subject: Re: RFR: 8234629: remove unused functions from libnet On 22/11/2019 13:29, Baesken, Matthias wrote: Hello, The linktime section-gc ( see also https://mail.openjdk.java.net/pipermail/build-dev/2019-November/026326.html ) found a couple of other potentially unused functions / variables in libnet . This change removes the found functions / variables. Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8234629 http://cr.openjdk.java.net/~mbaesken/webrevs/8234629.0/ Looks good to me (I was surprised to see setDefautScopeID/getDefaultScopeID as they came up in a recent change and I thought had been removed as part of that cleanup). -Alan