> On 18 Oct 2019, at 15:30, Julia Boes <julia.b...@oracle.com> wrote: > > > 1) Maybe add @Override to `public boolean usingProxy()`. ( pre-existing issue > ) > > 2) Maybe move the return on 3040 to a new line. Also use the curly braces > consistently, or not at all ;-) > > That's right! Thanks for reviewing, Chris. I added those two changes. > > Updated webrev: > http://cr.openjdk.java.net/~jboes/webrevs/8231632/webrev.02/index.html LGTM. -Chris.
- RFR: 8231632: HttpURLConnection::usingProxy could specify th... Julia Boes
- Re: RFR: 8231632: HttpURLConnection::usingProxy could s... Julia Boes
- Re: RFR: 8231632: HttpURLConnection::usingProxy cou... Chris Hegarty
- Re: RFR: 8231632: HttpURLConnection::usingProxy... Julia Boes
- Re: RFR: 8231632: HttpURLConnection::usingP... Chris Hegarty
- Re: RFR: 8231632: HttpURLConnection::u... Julia Boes
- Re: RFR: 8231632: HttpURLConnectio... Julia Boes
- Re: RFR: 8231632: HttpURLConne... Julia Boes
- Re: RFR: 8231632: HttpURLConne... Daniel Fuchs
- Re: RFR: 8231632: HttpURLConne... Chris Hegarty
- RE: RFR: 8231632: HttpURLConne... Vyom Tewari26