On 04/10/2019 14:55, Alan Bateman wrote:
On 04/10/2019 14:34, Daniel Fuchs wrote:
:
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8231260/webrev.00/
The apiNote looks okay. DatagramChannelImpl::disconnect looks okay but I
assume "might not preserve" should be "does not preserve" (if you make
that change then the "This is the expected ..." line isn't needed).
Thanks Alan.
The current wording was to make it clear that this behavior is not
considered as a bug in the Linux kernel.
But maybe it doesn't come out as I intended.
One suggestion is to rename the test to AddressesAfterDisconnect to make
it a bit clearer that it tests the local/remote addresses after
disconnect. I also assume we can change this to a TestNG test to avoid
the need for the assertXXX methods.
Good idea. I will work on that.
best regards,
-- daniel
