On 27/06/2019 12:30, Chris Hegarty wrote:
It is not an issue because there is an implicit reference ( from the nested class ). If we believe that the publisher is not strictly needed, then let's make the nested Subscription static, which will mean no ref, and is explicit. Concerns?
Not from me. But then it would be nice to have a comment wherever PullBlisher is not strongly referenced to explain that this is OK - so that next time we go over this code we don't have to double check again. best regards, -- daniel
