Hi Daniel,
On 21/06/2019, 17:54, Daniel Fuchs wrote:
Hi Michael,
Thanks for doing that. IT should make this test much more stable.
On 21/06/2019 17:27, Michael McMahon wrote:
There is a nio test, java/nio/channels/DatagramChannel/Promiscuous.java
that follows a similar pattern. Should it be updated in a similar way?
I notice that test uses a "reserved" multicast address, which
applications
are not supposed to use. Maybe, routers won't forward those packets
either.
I think I'd prefer to leave that test as it is, for now, especially
seeing as it
hasn't failed.
Related question:
java/net/MulticastSocket/Test.java uses "224.80.80.80".
Could that be changed as well without affecting the semantic of
the test?
That address (like the one in the NIO test mentioned earlier)
uses a reserved, but currently unassigned address.
I think I'd prefer to not change that for now.
Thanks,
Michael
I have been trying to find out how to fix this test so that it
pass on Mac. I was almost happy to have succeeded until I
tried when under a VPN, where the IPv4 test started failing :-(
I am wondering if using one of those unassigned addresses
instead of what we currently have could be considered?
Updated at:
http://cr.openjdk.java.net/~michaelm/8219804/webrev.2/
Looks good to me as well...
best regards,
-- daniel
Thanks,
Michael.
