Hi, Thanks, Arno. This looks good to me, too.
@Chris: We were running with this patch in our nightly test system for a while now and we don't see regressions. But looking forward to hear from your results. Best regards Christoph > -----Original Message----- > From: net-dev <net-dev-boun...@openjdk.java.net> On Behalf Of Zeller, > Arno > Sent: Dienstag, 28. Mai 2019 20:52 > To: Chris Hegarty <chris.hega...@oracle.com> > Cc: net-dev@openjdk.java.net > Subject: [CAUTION] RE: [RFR] 8194231: > java/net/DatagramSocket/ReuseAddressTest.java failed with > java.net.BindException: Address already in use: Cannot bind > > Hi Chris, > > thanks for having a look and running tests in your infrastructure. > > I updated the webrev in place with the missing whitespace in the copyright > header. I hope this is ok! > > Best regards, > Arno > > -----Original Message----- > From: Chris Hegarty <chris.hega...@oracle.com> > Sent: Dienstag, 28. Mai 2019 17:21 > To: Zeller, Arno <arno.zel...@sap.com> > Cc: net-dev@openjdk.java.net > Subject: Re: [RFR] 8194231: > java/net/DatagramSocket/ReuseAddressTest.java failed with > java.net.BindException: Address already in use: Cannot bind > > Arno, > > > On 28 May 2019, at 16:10, Zeller, Arno <arno.zel...@sap.com> wrote: > > > > Hi, > > > > I took a look at JDK-8194231 and would like to propose the following fix for > the issue. > > > > The problem seems that the test uses fixed port 5050 for testing that is > > also > used by newer Windows versions (Windows 10/Window Server 2016 and > newer). > > Therefore the test will always fail when run on a newer Windows machine. > To avoid such problems in the future I changed the three sub tests that use a > fixed port to use a generic port instead. > > > > Bug: > > 8194231: java/net/DatagramSocket/ReuseAddressTest.java failed with > java.net.BindException: Address already in use: Cannot bind > > https://bugs.openjdk.java.net/browse/JDK-8194231 > > > > Webrev: > > http://cr.openjdk.java.net/~azeller/webrevs/8194231/ > > I think this is good. > > I would like to run it through our internal build and test infra, after which > I’ll post the results here. > > Trivially, a space is needed after the coma in the copyright header. “2016, > 2019, " > > +/* Copyright (c) 2016,2019, Oracle and/or its affiliates. All rights > reserved. > > -Chris.
