Hi Vyom,

On 15/05/2019 11:25, Vyom Tiwari wrote:
Hi Daniel,

Changes looks good to me,

Thanks!

as you said code is copied from one test to another, i found FtpGetContent.java where same FtpServer code is copied.  Are you planning to fix FtpGetContent.java as well  ?.

Well - I wasn't intending to but it looks like a low
hanging fruit. All other tests in that directory either
do not use PASV or already support EPSV so it seems like
a low hanging fruit to bundle the same change FtpGetContent.java
and then we'll be done with it...

Here it goes...
http://cr.openjdk.java.net/~dfuchs/webrev_8223880/webrev.01/

best regards,

-- daniel



Thanks,
Vyom

Reply via email to