Hi Michael,
I'm too new to networking libs to actually review
this change. However I have eyeballed it and it looks
like a very nice simplification and cleanup!
I didn't see anything that looked wrong.
Two thing though:
java/net/Socket.java: (and at multiple other places in this file)
1615 // Before 1.3 Sockets were always connected during creation
I believe that with your change this comment is now obsolete.
Maybe it should be altered / removed?
AbsctractSocketImpl/PlainSocketImpl:
It's a bit surprising that createSocket has now acquired
an isServer boolean, as it makes it look as if a value
different than that given to the constructor could be
passed in. Aren't the PlainSocketImpl subclasses all able
to access this `isServer` field?
I understand that the unix impl needs to pass the value
of that field to the native, but maybe it could simply
have a one arg java createSocket method that calls
the underlying two args native impl?
best regards,
-- daniel
On 29/04/2019 10:52, Michael McMahon wrote:
Hi,
This is another change which is part of the general cleanup of SocketImpls.
The change removes support for pre JDK 1.4 socketimpls which do not
implement
the timed connect method. These SocketImpls have not been compilable
since 1.4 and limited runtime support has been provided since then,
which is now being removed.
Webrev
-------
http://cr.openjdk.java.net/~michaelm/8216978/webrev.1/
CSR
----
https://bugs.openjdk.java.net/browse/JDK-8222546
Thanks,
Michael.
