Arthur, > On 1 Apr 2019, at 21:52, Arthur Eubanks <aeuba...@google.com> wrote: > > There are a bunch of tests with "-Djava.net.preferIPv4Stack=true", which > should clearly fail in an IPv6 only environment.
Right. > Would skipping these when IPv4 is not supported be okay? Yes, I believe so, but we will need to check what specific functionality that the test is exercising. In many cases it's just the TCP/UDP stack without IPv6 support, to exercise more code paths. These cases should be fine to be excluded for IPv6-only environments. I'll play a little with the jtreg @requires functionality, but depending on the test structure and the existing @run tags, it may be more straight forward to just check for the presence of the system property and platform support ( wrapped up into a convenient test library function ), returning early from the test where it doesn't make sense to run on that configuration. > I see that some tests with "-Djava.net.preferIPv6Addresses=true" will pass > even if the IPv6 part of the test failed. Do you have a list of these? > On Fri, Mar 29, 2019 at 12:59 PM Arthur Eubanks <aeuba...@google.com > <mailto:aeuba...@google.com>> wrote: > ... Also, we don't have a JDK at head which works in our environments, so we > might miss some failures until we've decided to have a JDK at head that works > in our environments and run all of the networking tests. Right, there is a chicken and egg problem here, but you are correct that we need to make progress on an IPv6-only JDK build. If not yet integrated, at least a generally agreed patch / approach. -Chris.
