On 06/06/2018 08:45, Michael McMahon wrote:
Hi all,
Finally to return to this topic. We have looked at a few different
approaches
and it seems the best way is to define a security property that can be set
in the java.security configuration file, but which can be overridden as a
system property. The current behavior will remain the default, but setting
the property will add addressing information to exception texts.
The change applies to all TCP socket types in java.net and java.nio.
Webrev at:
http://cr.openjdk.java.net/~michaelm/8204233/webrev.1/index.html
This looks quite good and the ability to use a system property to
override the java.security file is useful for ad hoc enabling. The
property name can probably be improved The jdk.net prefix looks right
but jdk.net.enhanceExceptionText isn't very clear, esp. when used on the
command line. It feels it should something like
jdk.net.includeHostInfoInExceptions or something that makes it clear
that it adds host information to socket exceptions.
I see Jaikiran Pai spotted the close was accidentally removed from
AbstractPlainSocketImpl so I assume you'll fix that.
Aside from AsynchronousCloseException, are there are other IOException
classes that don't have the 1-arg String constructor. Just wondering if
it would be better to special case that to not use SocketExceptions or
alternative not rely on catching NoSuchMethodException.
-Alan
