Hi, On Tue, Dec 12, 2017 at 7:04 PM, Chris Hegarty <chris.hega...@oracle.com> wrote: > >> On 12 Dec 2017, at 17:43, Daniel Fuchs <daniel.fu...@oracle.com> wrote: >> >> Hi, >> >> please find below a patch for: >> >> 8193370 Provide more user friendly defaults for HTTP/2 client settings >> https://bugs.openjdk.java.net/browse/JDK-8193370 >> >> webrev: >> http://cr.openjdk.java.net/~dfuchs/webrev_8193370/webrev.01/ > > This looks good Daniel. It is good that you have added restrictions > on the allowable values for some of these settings, some of which > are specified by the RFC. I also agree with the increase is window > sizes. This should improve overall throughput and reduce network > trashing from windows updates.
Do I read it correctly that the default session window is 1 GiB ? This would impose on the client a large memory requirement especially when connecting to multiple domains. I would suggest smaller values. Our experience is that even in fast network (not localhost) 16 MiB session windows will hit TCP congestion control before stalling HTTP/2 flow control. -- Simone Bordet --- Finally, no matter how good the architecture and design are, to deliver bug-free software with optimal performance and reliability, the implementation technique must be flawless. Victoria Livschitz
