Re: RFR 8183514/10, Remove intermittent key from httpclient test TimeoutOrdering and ErrorTest

[Daniel Fuchs]

Looks good to me Felix!

Thanks,

-- daniel

On 04/07/2017 07:23, Felix Yang wrote:

Hi there,

     please review a patch to remove intermittent key from

test/java/net/httpclient/TimeoutOrdering.java

test/java/net/httpclient/http2/ErrorTest.java.

They have been observed to be stable after fixing of related bugs.

Bug:

     https://bugs.openjdk.java.net/browse/JDK-8183514

Patch:

diff -r e99004ee6f13 test/java/net/httpclient/TimeoutOrdering.java

--- a/test/java/net/httpclient/TimeoutOrdering.java Mon Jul 03 12:54:24 2017 -0700 +++ b/test/java/net/httpclient/TimeoutOrdering.java Mon Jul 03 22:39:14 2017 -0700

@@ -38,7 +38,6 @@

  /**
   * @test
- * @key intermittent

* @summary Ensures that timeouts of multiple requests are handled in correct order

   * @run main/othervm TimeoutOrdering
   */
diff -r e99004ee6f13 test/java/net/httpclient/http2/ErrorTest.java

--- a/test/java/net/httpclient/http2/ErrorTest.java Mon Jul 03 12:54:24 2017 -0700 +++ b/test/java/net/httpclient/http2/ErrorTest.java Mon Jul 03 22:39:14 2017 -0700

@@ -25,7 +25,6 @@
   * @test
   * @bug 8157105
   * @library /lib/testlibrary server
- * @key intermittent
   * @build jdk.testlibrary.SimpleSSLContext
   * @modules jdk.incubator.httpclient/jdk.incubator.http.internal.common
   * jdk.incubator.httpclient/jdk.incubator.http.internal.frame

Thanks,

Felix