You're right Daniel. It's actually a vestige of the original intention
to support pipelined requests, which are not supported. getBuffer() is actually called from Http1Response, but it would be better to get the empty buffer reference
at that point.

Thanks
Michael

On 19/05/2017, 17:42, Daniel Fuchs wrote:
Hi Michael,

Looks good - but what purpose does the rxBuffer now
serves in Exchange.java?

If I'm not mistaken it's an empty 0 sized buffer that
is never replaced... At the very least it should be
final (and not volatile), but maybe getBuffer() could
simply be removed here?

best regards,

-- daniel

On 19/05/2017 15:29, Michael McMahon wrote:
Could I get the following change reviewed please?

Bug: https://bugs.openjdk.java.net/browse/JDK-8180498

Webrev: http://cr.openjdk.java.net/~michaelm/8180498/webrev.1/

Thanks,
Michael.

Reply via email to