Hi Rob, this looks like a nice fix and I can't see anything besides the copyright year which you will for sure update when submitting. :)
Unfortunately I'm not a reviewer so you'll have to get another real review. Best regards Christoph > -----Original Message----- > From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Rob > McKenna > Sent: Mittwoch, 21. September 2016 17:17 > To: net-dev@openjdk.java.net > Subject: RFR - 8159410: InetAddress.isReachable returns true for non existing > IP > addresses > > Hi folks, > > I'd like to fix a bug caused by an incorrect assumption. The IcmpSendEcho* > calls can actually return a similar set of errors regardless of whether the > call > itself failed or succeeded. This change checks that both the call and the ping > were successful. In addition to that it takes a number of common failure > causes > into account before deciding to throw an exception. > > http://cr.openjdk.java.net/~robm/8159410/webrev.01/ > > -Rob