On 20/05/2016 11:16, Svetlana Nikandrova wrote:
Hi Artem,
thank you for your comments. Please see updated review:
http://cr.openjdk.java.net/~snikandrova/8136933/webrev.01/
<http://cr.openjdk.java.net/%7Esnikandrova/8136933/webrev.01/>
I've moved version check to OSInfo.java and used ProcessTools. Also
made a little change in ProcessTools (Throwable didn't make sense
there). I also updated comment for checkSocketOption() method to
indicate that it is fine to not get any exception. Actually as this
test is meant to check platform support we are only interested in
UnssuportedOperationException. More usage scenarios with SO_FLOW_SLA
option are covered by
http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/test/jdk/net/Sockets/Test.java
Yes, there is an existing test in test/jdk/net/Sockets/Test.java and
seems strange to have the tests in different locations (maybe some
overlapping coverage too).
-Alan
