* I see that there is an issue for autoponging. May be this falls under it.
The default impl of onPing() doesn't send PONG for *every* received PING.
Since it is against the protocol semantics, it forces all applications to
override the default onPing() impl. Is that right ?

It seems to me that the basic issue here is that API allows only one
outstanding send operation. That is also limiting for applications as
applications need to do more work.

* Since API allows these callback methods may be called by different
threads, it is application responsibility to manage memory visibility and
thread safety etc, right ?

On Tue, May 3, 2016 at 8:23 AM, Pavel Rappo <pavel.ra...@oracle.com> wrote:

>
> Hello,
>
> Here's an updated webrev with the latest implementation:
>
>    http://cr.openjdk.java.net/~prappo/8087113/webrev.04/
>
> If you're going to review it, please be advised that there is a number of
> known
> API and implementation issues yet to be resolved [1]. More API tests will
> be
> provided in the next couple of months.
>
> All applicable tests (1.1.1-10.1.1, 305 in total) from Autobahn Testsuite
> [2]
> are green.
>
> Thanks,
> -Pavel
>
>
> --------------------------------------------------------------------------------
> [1] https://bugs.openjdk.java.net/browse/JDK-8155621
> [2] http://autobahn.ws/testsuite/
>
> > On 25 Mar 2016, at 16:21, Pavel Rappo <pavel.ra...@oracle.com> wrote:
> >
> > Hi,
> >
> > Could you please review my change for JDK-8087113
> >
> >   http://cr.openjdk.java.net/~prappo/8087113/webrev.03/
> >
> > This webrev contains initial implementation and basic tests for
> WebSocket API.
> > Specification conformance & interoperability testing has been performed
> with
> > Autobahn Testsuite [1]. As for API tests, I will provide more of them
> later.
> >
> > Thanks,
> > -Pavel
> >
> >
> --------------------------------------------------------------------------------
> > [1] http://autobahn.ws/testsuite/
> >
>
>

Reply via email to