Hi Mandy,

On 06/03/16 00:01, Mandy Chung wrote:
Hi Daniel,

On Mar 4, 2016, at 8:05 AM, Daniel Fuchs <daniel.fu...@oracle.com> wrote:

Please find below a patch for:

https://bugs.openjdk.java.net/browse/JDK-8151281
8151281: Module java.httpclient could use System.Logger
         instead of PlatformLogger

http://cr.openjdk.java.net/~dfuchs/webrev_8151281/webrev.00/


I’m happy to see usage of PlatformLogger being converted to System.Logger.

Is there any reason why Log can’t be a concrete implementation class?

It could but it would still be a bit artificial and would add an
extra call layer in the call stack. I considered it but opted for
the simpler solution.

Can it extends SimpleConsoleLogger instead?

No. SimpleConsoleLogger is designed to be a 'terminal' logger
(I mean - not a wrapper) that publishes on System.err.
(+ it would require a qualified export from java.base)

best regards,

-- daniel



Mandy


Reply via email to