Hi Sean, Since I saw the convention of filenames being a bug id, I had created a new test. :) Anyways, I have updated the existing test with my bug id. Here is the updated Webrev: http://cr.openjdk.java.net/~rpatil/8135259/webrev.02/
Regards, Ramanand. -----Original Message----- From: Seán Coffey Sent: Friday, February 12, 2016 2:38 PM To: Ramanand Patil; Ivan Gerasimov; OpenJDK Network Dev list Subject: Re: [PING] RFR: JDK-8135259: InetAddress.getAllByName only reports "unknown error" instead of actual cause Thanks for the test Ramanand. One possibility here is to enhance an existing test to check for your condition. I think test/java/net/InetAddress/B6246242.java is a suitable edit. You can add your bug ID to the @bug tag. Would that work ? Regards, Sean. On 11/02/2016 02:37, Ramanand Patil wrote: > Hi Sean, > > Thank you. I have updated copyright year to the earlier patch and added a > simple test case to cover this bug. > Please review the updated Webrev: > http://cr.openjdk.java.net/~rpatil/8135259/webrev.01/ > > Regards, > Ramanand. > > -----Original Message----- > From: Seán Coffey > Sent: Wednesday, February 10, 2016 7:47 PM > To: Ivan Gerasimov; Ramanand Patil; OpenJDK Network Dev list > Subject: Re: [PING] RFR: JDK-8135259: InetAddress.getAllByName only > reports "unknown error" instead of actual cause > > (dropping core-libs) > > src change looks good to me also Ramanand. Will you also be adding a testcase > to cover this ? I'm sure you could find one in the test base for editing. > > Regards, > Sean. > > On 10/02/16 13:44, Ivan Gerasimov wrote: >> Hi Ramanand! >> >> Your fix looks good to me. >> >> I'm forwarding your request to net-dev@openjdk.java.net which is >> probably more appropriate to review this fix. >> It would be good, if net-dev people can confirm they're Okay with the >> fix. >> >> Sincerely yours, >> Ivan >> >> >> On 10.02.2016 10:08, Ramanand Patil wrote: >>> Hi all, >>> >>> Please help me in getting this review done. >>> >>> Regards, >>> Ramanand. >>> >>> -----Original Message----- >>> From: Ramanand Patil >>> Sent: Friday, February 05, 2016 10:46 PM >>> To: core-libs-...@openjdk.java.net >>> Subject: RFR: JDK-8135259: InetAddress.getAllByName only reports >>> "unknown error" instead of actual cause >>> >>> Hi all >>> Please review the fix for bug: >>> https://bugs.openjdk.java.net/browse/JDK-8135259 >>> >>> Bug Description: Attempts to resolve a host unknown to the DNS >>> server cause an UnknownHostException stating "unknown error" instead >>> of "Name or service not known". >>> >>> Webrev: http://cr.openjdk.java.net/~rpatil/8135259/webrev.00/ >>> >>> Fix: Using a function call directly "gai_strerror(gai_error)" >>> instead of using the function pointer which was declared but not >>> initialized. >>> Apart from this I have removed few other unused variables and >>> function pointers. Brief description of how this bug was introduced >>> is added to the bug comment. >>> >>> Regards, >>> >>> Ramanand. >>> >>>
