On 23/12/2015 11:22, Svetlana Nikandrova wrote:
Little remainder.
On 19.12.2015 1:32, Svetlana Nikandrova wrote:
Alan, Michael,
thank you for your feedback.
As you suggested I moved checking code down to the implementation.
Please see updated webrev:
http://cr.openjdk.java.net/~kshefov/8143554/webrev.02/
<http://cr.openjdk.java.net/%7Ekshefov/8143554/webrev.02/>
Thank you,
Svetlana
The update to PlainSocketImpl and PlainDatagramSocketImpl look okay,
just a minor nit that "if(" should be "if (" to keep the code consistent.
For SocketImpl then I assume the getSocket() check is because these are
Socket rather than ServerSocket options.
There are few formatting issues in the test that would be good to fix up
before this is pushed, otherwise the test looks okay to me.
-Alan
