Pavel, The latest changes look good to me. Can you please add a license header to the service descriptor file ( I know we don't do this consistently ).
-Chris > On 24 Jun 2015, at 13:20, Pavel Rappo <pavel.ra...@oracle.com> wrote: > > Thanks Alan. Both issues are fixed now, webrev updated in place. > >> On 24 Jun 2015, at 12:31, Alan Bateman <alan.bate...@oracle.com> wrote: >> >> >> >>> On 24/06/2015 12:08, Pavel Rappo wrote: >>> Hi everyone, >>> >>> Could you please review my change for JDK-8064925? >>> >>> http://cr.openjdk.java.net/~prappo/8064925/webrev.01/ >>> >>> The main goal is to see if the proposed spec change and the overall >>> approach are >>> correct. >> The update to the API docs looks good to me. >> >> One thing that will need to be added before you are finished is a >> META-INF/services/java.net.ContentHandlerFactory file to list >> sun.awt.www.content.MultimediatContentHandlers as otherwise this factory >> will not be located. >> >> Minor comment in ContentHandler is that c is a raw type. >> >> -Alan >
