Looks ok Felix. You could put the construction of the new DatagramSocket in a try-with-resources, so it will be closed always, even if the test fails.
-Chris > On 29 Dec 2014, at 10:04, FELIX YANG <felix.y...@oracle.com> wrote: > > Hi all, > please review the fix for 8042581. This failure was only observed on > Windows, so it is most possibly because the socket.close() on Windows is > processed asynchronously within the Windows API layer (TCP machine) . Add 5 > times of tries to the test if BindException is encountered on Windows. > > Webrev: > http://cr.openjdk.java.net/~xiaofeya/8042581/webrev.00/ > Bug: > https://bugs.openjdk.java.net/browse/JDK-8042581 > > Thanks! > -Felix > >
