On 02/10/2014 11:17, Kirk Shoop (MS OPEN TECH) wrote:
:
We tried the suggestions in this thread and the result is a much smaller patch
that works as well as the previous patch.
https://openjdkcontrib.blob.core.windows.net/tcploopback/webrev-20141002.zip
GetVersionEx is not used and the IOCTL is applied when the socket is
constructed.
Thanks for sending us back for another look,
This looks much better and I can sponsor this.
One that we need to decide on is the system property to enable this. You
are currently using "windows.enableFastLocalTcpLoopback". In recent time
we have been using "jdk.*" for JDK-specific properties. What would you
think about renaming it to jdk.net.useFastLocalTcpLookack"?
Another thing that I meant to ask is whether we can skip this for UDP
sockets. In Net.socket0 for example then I assume it should be "if
(stream && fastLookback)".
-Alan
