On 09/06/2014 18:06, Pavel Rappo wrote:
This looks good to me. I have not looked at the test, I see Chris has reviewed it though.Alan, it looks simpler, indeed:http://cr.openjdk.java.net/~prappo/8027308/webrev.01/src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java.sdiff.html I have removed the StringBuilder completely. It doesn't seem to be a performance critical part of the code :) But from the readability perspective this is a lot better.
-Alan