On 24/03/14 16:17, Alan Bateman wrote:
On 24/03/2014 14:09, Chris Hegarty wrote:
Alan, Dmitry,

I updated the webrev. It now allocates memory dynamically, and asserts
that the number of bytes read is less than the size of
sctp_notification ( for notifications ).

http://cr.openjdk.java.net/~chegar/8034181/webrev.01/webrev/

-Chris.
This looks okay to me and I wouldn't expect the malloc'ed case to be
common.

One comment on the test is that "75" isn't obvious and might be useful
as a constant at the top to explain that it's the total number of
combinations.

Thanks Alan. I'll do that before pushing.

-Chris.


-Alan

Reply via email to