On 02/14/2014 05:45 PM, Chris Hegarty wrote:
On 14/02/14 14:04, Alan Bateman wrote:
On 14/02/2014 13:52, Florian Weimer wrote:
This patch removes support for old, pre-1.4 SocketImpl and
DatagramSocketImpl classes. Compiling these classes has been
impossible since 1.4 because 1.4 added new abstract methods to the
base classes.
Is this okay in principle? Could you create bug ID for this?
I don't have any objection but I think it requires a bit of discussion
and some insight into whether anyone might be running with ancient
SocketImpl (that would have been compiled a long time ago).
It would certainly be nice to remove this old crud, if only as a clean
up exercise, but I'm just wondering about the motivation for this.
Reducing footprint, and avoiding the hazard that behavior changes if the
most derived class does not implement the magic method so that
getDeclaredMethod() fails. Only one of the checkOldImpl() methods has
the loop that looks at base classes.
--
Florian Weimer / Red Hat Product Security Team
