Hi Mandy,

Good point; I'll create another issue to do that update.
(I should have waited a bit longer for comments.)

Roger

On 1/10/2014 12:41 PM, Mandy Chung wrote:
On 1/10/2014 7:37 AM, roger riggs wrote:
Please review:

To enable native code checking consistently for thrown exceptions,
the macros in net_util.h and java/util/jar/pack/coding.cpp are
made consolidated and promoted to jni_util.h

webrev:
http://cr.openjdk.java.net/~rriggs/webrev-check-exception-8030875/


Looks good. Thanks for doing this Roger. Minor nit: the convention in jni.h seems to name functions that take JNIEnv* parameter with the "JNU_" prefix and so might be better to rename CHECK_EXCEPTION to JNU_CheckedException.

Mandy


Reply via email to